Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggested deps #75

Merged
merged 4 commits into from
Feb 4, 2025
Merged

suggested deps #75

merged 4 commits into from
Feb 4, 2025

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Dec 12, 2024

Fix #40
Fix #64

@maelle maelle requested a review from jeroen December 12, 2024 13:23
@maelle
Copy link
Collaborator Author

maelle commented Dec 19, 2024

A case not using the field: https://github.com/cran/prioritizr/blob/0738fe58f55c812a3023e81398d4294487a8c497/DESCRIPTION#L21

@jeroen
Copy link
Member

jeroen commented Dec 19, 2024

I think some people will not like we use rlang for no reason. Let's just use base R if(!(require("pkg")) ...

@maelle
Copy link
Collaborator Author

maelle commented Dec 20, 2024

@jeroen Good point!

  • I added the base R solution but also kept the rlang one as that's a handy one.
  • I added another approach that was discussed in the rOpenSci slack.

@maelle
Copy link
Collaborator Author

maelle commented Jan 13, 2025

@jeroen friendly reminder 😸

@jeroen jeroen merged commit 78dda80 into main Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroen jeroen Awaiting requested review from jeroen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suggested deps
2 participants
@maelle @jeroen