-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs and guides for --use-wallet
#16
Conversation
[sc-1779] |
pop-cli-for-smart-contracts/.gitbook/assets/use-wallet/connect-wallet.png
Outdated
Show resolved
Hide resolved
pop-cli-for-smart-contracts/guides/securely-sign-transactions-from-cli.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I included a brief comment about wallet integration in the parachain onboarding docs.
Also as suggested by Ale here: #16 (comment) I updated image to show all wallets, but feel free to pick the one you prefer.
* docs: include use-wallet info in the parachain onboarding docs * style: update connect-wallet.png to show all wallets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
pop-cli-for-smart-contracts/guides/securely-sign-transactions-from-cli.md
Outdated
Show resolved
Hide resolved
pop-cli-for-smart-contracts/guides/securely-sign-transactions-from-cli.md
Outdated
Show resolved
Hide resolved
pop-cli-for-appchains/guides/securely-sign-transactions-from-cli.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just three quick fixes please and then good to approve.
Co-authored-by: Frank Bell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Direct links: