Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and guides for --use-wallet #16

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Docs and guides for --use-wallet #16

merged 7 commits into from
Dec 19, 2024

Conversation

peterwht
Copy link
Contributor

@peterwht peterwht commented Dec 18, 2024

@peterwht
Copy link
Contributor Author

[sc-1779]

@peterwht peterwht requested a review from AlexD10S December 18, 2024 02:34
@AlexD10S AlexD10S mentioned this pull request Dec 18, 2024
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I included a brief comment about wallet integration in the parachain onboarding docs.

Also as suggested by Ale here: #16 (comment) I updated image to show all wallets, but feel free to pick the one you prefer.

@AlexD10S AlexD10S requested a review from al3mart December 18, 2024 16:03
AlexD10S and others added 2 commits December 18, 2024 12:01
* docs: include use-wallet info in the parachain onboarding docs

* style: update connect-wallet.png to show all wallets
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just three quick fixes please and then good to approve.

Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@AlexD10S AlexD10S merged commit bb289ce into main Dec 19, 2024
7 checks passed
@AlexD10S AlexD10S deleted the peter/docs-use-wallet branch December 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants