style: naming examples #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pop-api is included in the path, so having it in the contract names seems redundant. Simpler to just remove the |
Daanvdplas
force-pushed
the
daan/fix_example_names
branch
from
f77f2bb
to
5c00397
Compare
Daanvdplas
commented
Apr 22, 2024
There was a problem hiding this comment.
In general, I would remove the pop_api_ or PopApi prefix and just name it according to the name of the top level folder.
Similar to https://github.com/paritytech/ink-examples
Daanvdplas
commented
Apr 24, 2024
al3mart
approved these changes
Apr 29, 2024
Daanvdplas
force-pushed
the
daan/fix_example_names
branch
from
a890520
to
dd2c836
Compare
al3mart
approved these changes
Apr 29, 2024
brunopgalvao
approved these changes
Apr 30, 2024
|
Closed by #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a warning in compiling a contract when adding pop api dependency. This should resolve it.
I also updated the naming, which we can use to move forward with the examples.
This is just naming things, examples need a lot more work.