Adding Chapter 3 content for 10/4/2023 meeting #2
Conversation
|
Right, I forgot that cuda operations won't work in the GiHub workflow. Theoretically the book examples can all be run on CPU. I'll comment out a couple of cuda specific lines of code and re-submit a pull request. |
Head branch was pushed to by a user without write access
|
@AmandaRP Run this at your command line, and push the resulting DESCRIPTION (or you can add torch directly, but it's good to get in the habit of usethis workflows!) It definitely won't build without that, and we'll likely have to update the GHA to tell it to install torch. I'll pull up some of my torch-using remind myself how that works... |
There was a problem hiding this comment.
Is it possible to not use the okc dataset in the notes (either by not actually rendering whatever you do with it, or by switching to a different dataset)? It was deprecated due to concerns with the data. It's one thing for the book to use it, but we shouldn't propagate the issues (and installing the old version is a huge pain).
|
Gotcha. I'll look at using a different dataset. |
Merge branch 'chapter-3' of https://github.com/AmandaRP/bookclub-torch into chapter-3 # Conflicts: # DESCRIPTION
|
Looks like |
|
@jonthegeek , Where in the repo would it be best to add the |
|
@AmandaRP I'm so sorry, this fell off my to-do list! I'm pretty sure I've gotten torch working in GHA before, so I'll spend the next hour or two sorting this out (I hope)! |
|
OK, no rush! I was just looking at it too see if I should do something, but wasn't sure the best approach. Thanks for your help! |
I'm not confident this will work but we might as well try!
One more try at a quick fix before reading documentation.
Probably still won't work but it's closer.
So if earlier chapters use it in later clubs, it's set to go.
No description provided.