Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make segment fadvise option configurable.
It is not clear if
random
ornormal
is the better option for external read plan segment reads so this is now configurable.This setting also affects segments opened for append as when the segment is full and is closed we perform an fadvise call. By default this is set to
dont_need
to ensure page cache data is reclaimed after a segment flush.When closing the WAL we also set
dont_need
advise as this data is unlikely to ever be read again.