Merge pull request #12700 from rabbitmq/v4.0.x-connection-tracking-crash

Fix crashes in connection tracking
rabbitmq · Nov 11, 2024 · 5b27204 · 5b27204
2 parents 147ff24 + 67e0ee0
commit 5b27204
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/deps/rabbit/src/rabbit_connection_tracking.erl b/deps/rabbit/src/rabbit_connection_tracking.erl
@@ -35,7 +35,7 @@
          list/0, list/1, list_on_node/1, list_on_node/2, list_of_user/1,
          tracked_connection_from_connection_created/1,
          tracked_connection_from_connection_state/1,
-         lookup/1, count/0]).
+         lookup/1, lookup/2, count/0]).
 
 -export([count_local_tracked_items_in_vhost/1,
          count_local_tracked_items_of_user/1]).
@@ -233,8 +233,8 @@ lookup(Name, [Node | Nodes]) when Node == node() ->
     end;
 lookup(Name, [Node | Nodes]) ->
     case rabbit_misc:rpc_call(Node, ?MODULE, lookup, [Name, [Node]]) of
-        [] -> lookup(Name, Nodes);
-        [Row] -> Row
+        not_found -> lookup(Name, Nodes);
+        Row = #tracked_connection{} -> Row
     end.
 
 lookup_internal(Name, Node) ->