amqp_client_SUITE: Fix several test flakes #13147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[How] 1. Use feature flags correctly: the code shouldn't test if a feature flag is enabled, assuming something else enabled it. It should enable it and react to an error. 2. Use `close_connection_sync/1` instead of the asynchronous `amqp10_client:close_connection/1` to make sure they are really closed. The wait in `end_per_testcase/2` was not enough apparently. 3. For the two testcases that flake the most for me, enclose the code in a try/after and make sure to close the connection at the end, regardless of the result. This should be done for all testcases because the testgroup use a single set of RabbitMQ nodes for all testcases, therefore testcases are supposed to clean up after them...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How
close_connection_sync/1instead of the asynchronousamqp10_client:close_connection/1to make sure they are really closed. The wait inend_per_testcase/2was not enough apparently.