Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): Ditch registry system provider #445

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

rabbitstack
Copy link
Owner

@rabbitstack rabbitstack commented Feb 19, 2025

What is the purpose of this PR / why it is needed?

After exhaustive triaging, it was spotted that the system registry provider can miss stackwalk samples. This can have disastrous consequences such as wrongly attributing stack return addresses or accumulated events. To elegantly mitigate the problem, we enable the registry flags on the system logger and receive all events within the same session. As a result, the Registry System Logger session/consumer are eliminated.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


@rabbitstack rabbitstack linked an issue Feb 19, 2025 that may be closed by this pull request
@rabbitstack rabbitstack force-pushed the ditch-registry-system-provider branch 2 times, most recently from 0e260db to 818fa7b Compare February 25, 2025 19:41
After exhaustive triaging, it was spotted that the system registry provider can miss stackwalk samples.
This can have disastrous consequences such as wrongly attributing stack return addresses or accumulated events.
To elegantly mitigate the problem, we enable the registry flags on the system logger and receive all events within the same session.
@rabbitstack rabbitstack merged commit 33d4a67 into master Feb 25, 2025
9 checks passed
@rabbitstack rabbitstack deleted the ditch-registry-system-provider branch February 25, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden Registry Key Name Not Accurately Reported in Logs
1 participant