Don't call start-renderer when there are no renderers (#79, #49)

racket · Sep 23, 2020 · ba879fc · ba879fc
1 parent 61afacb
commit ba879fc
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 8 deletions.
diff --git a/plot-lib/plot/private/no-gui/plot2d-utils.rkt b/plot-lib/plot/private/no-gui/plot2d-utils.rkt
@@ -70,11 +70,10 @@
 
   (for ([rend  (in-list renderer-list)])
     (match-define (renderer2d rend-bounds-rect _bf _tf label-proc render-proc) rend)
-    ;; next step could be moved into (when render-proc, but this generates different step files)
-    (send area start-renderer (if rend-bounds-rect
-                                  (rect-inexact->exact rend-bounds-rect)
-                                  (unknown-rect 2)))
     (when render-proc
+      (send area start-renderer (if rend-bounds-rect
+                                    (rect-inexact->exact rend-bounds-rect)
+                                    (unknown-rect 2)))
       (render-proc area)))
 
   (send area end-renderers)

diff --git a/plot-lib/plot/private/no-gui/plot3d-utils.rkt b/plot-lib/plot/private/no-gui/plot3d-utils.rkt
@@ -80,11 +80,10 @@
 
   (for ([rend  (in-list renderer-list)])
     (match-define (renderer3d rend-bounds-rect _bf _tf label-proc render-proc) rend)
-    ;; next step could be moved into (when render-proc, but this generates different step files)
-    (send area start-renderer (if rend-bounds-rect
-                                  (rect-inexact->exact rend-bounds-rect)
-                                  (unknown-rect 3)))
     (when render-proc
+      (send area start-renderer (if rend-bounds-rect
+                                    (rect-inexact->exact rend-bounds-rect)
+                                    (unknown-rect 3)))
       (render-proc area)))
 
   (send area end-renderers)

diff --git a/plot-test/plot/tests/test-data/p2d-4.dat b/plot-test/plot/tests/test-data/p2d-4.dat
diff --git a/plot-test/plot/tests/test-data/p2d-4.png b/plot-test/plot/tests/test-data/p2d-4.png
diff --git a/plot-test/plot/tests/test-data/tt-24.dat b/plot-test/plot/tests/test-data/tt-24.dat
diff --git a/plot-test/plot/tests/test-data/tt-24.png b/plot-test/plot/tests/test-data/tt-24.png
diff --git a/plot-test/plot/tests/test-data/tt-30.dat b/plot-test/plot/tests/test-data/tt-30.dat
diff --git a/plot-test/plot/tests/test-data/tt-30.png b/plot-test/plot/tests/test-data/tt-30.png