feat: support #:auto-value for defparam and defthing #391
Conversation
sorawee
force-pushed
the
auto-value
branch
2 times, most recently
from
6bb2641 to
d9c234a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 3 files in this pull request and found no issues.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
This strategy is not foolproof though. For example, https://github.com/racket/scribble/blob/master/scribble-doc/scribblings/scribble/utils.rkt#L12-L13 bounces the for-label binding, but not the phase 0 binding. So without |
|
Switching from the third result to the first result ( |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
sorawee
force-pushed
the
auto-value
branch
2 times, most recently
from
0cad1b2 to
7d6181d
Compare
|
Addressed feedback by @rocketnia. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Manually specifying `#:value` could be cumbersome. An example is `html-empty-tags` from the `xml` collection, which is a list of more than 10 symbols. It is also error-prone, and could be out-of-sync from the actual value. This PR adds a support for `#:auto-value` in `defparam` and `defthing` to automatically query the value from the `for-label` binding. The original idea of this PR is from racket/racket#4807. Thanks to @LiberalArtist who recommended an implementation strategy, and @rocketnia for feedback.
There was a problem hiding this comment.
Resyntax analyzed 3 files in this pull request and found no issues.
|
Oof, I should have bumped the version and added a history note. Will push a fix. |
Manually specifying
#:valuecould be cumbersome. An example ishtml-empty-tagsfrom thexmlcollection, which is a list of more than 10 symbols.It is also error-prone, and could be out-of-sync from the actual value.
This PR adds a support for
#:auto-valueindefparamanddefthingto automatically query the value from thefor-labelbinding.Thanks to @LiberalArtist for the help in racket/racket#4807.