Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeset: correct the form of code:contract# and code:quote #398

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

sorawee
Copy link
Contributor

@sorawee sorawee commented Dec 19, 2023

  • code:contract# only allows one subform in the implementation, but the documentation allows many subforms.
  • code:quote only allows one subform in the documentation, but the implementation allows many subforms.

This PR corrects both the implementation and the documentation so that the implementation and the documentation agree with each other.

`code:contract#` only allows one subform in the implementation.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 0 files in this pull request and found no issues.

@sorawee
Copy link
Contributor Author

sorawee commented Dec 19, 2023

Conversely, (code:quote a b c) is actually allowed in the implementation, even though the documentation says only one form is allowed. We should make them agree. Should we fix the doc or the implementation?

@mfelleisen
Copy link
Contributor

My preference would be to go with one item per form: (code:quote _datum) and (code:contract# _datum)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 1 file in this pull request and found no issues.

@sorawee sorawee changed the title doc: correct the form of code:contract# typeset: correct the form of code:contract# and code:quote Dec 21, 2023
@sorawee sorawee merged commit 338a53e into master Dec 21, 2023
3 checks passed
@sorawee sorawee deleted the codecontractsharp branch December 21, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants