-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newrelic mysql plugin support to stack_commons::newrelic #51
Conversation
@@ -26,7 +28,6 @@ | |||
depends 'python' | |||
depends 'rabbitmq' | |||
depends 'rackspace_gluster' | |||
depends 'redisio' | |||
depends 'redis-multi' | |||
depends 'uwsgi' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove this too :P
This PR is blocked for now I think, It's passing the tests locally. However in Jenkins :
I think it's due to a definition called install_plugin in newrelic_plugins_chef https://github.com/newrelic-platform/newrelic_plugins_chef/blob/ba9ddd843560894494d134f67596a84ce5c4a172/definitions/install_plugin.rb, and one in elasticsearch https://github.com/elasticsearch/cookbook-elasticsearch/blob/master/libraries/install_plugin.rb#L35. so when newrelic_plugins_chef recipe is calling its definition to install a plugin, it actually triggers the elasticsearch plugin install. I need to investigate more :-( |
It's passing now with my fork : newrelic/newrelic_plugins_chef#29 I'm not sure it will be accepted upstream, so I'm trying to update our old rackspace_fork rackspace-cookbooks/newrelic_plugins_chef#1 |
retest this please |
1 similar comment
retest this please |
and succeed please |
@lmunro FYI, as you are reviewing 😉
|
Add newrelic mysql plugin support to stack_commons::newrelic
No description provided.