Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newrelic mysql plugin support to stack_commons::newrelic #51

Merged
merged 10 commits into from
Nov 3, 2014

Conversation

jujugrrr
Copy link
Contributor

No description provided.

@@ -26,7 +28,6 @@
depends 'python'
depends 'rabbitmq'
depends 'rackspace_gluster'
depends 'redisio'
depends 'redis-multi'
depends 'uwsgi'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove this too :P

@jujugrrr
Copy link
Contributor Author

This PR is blocked for now I think, It's passing the tests locally. However in Jenkins :

stack_commons::newrelic on Centos 6.5 mysql with java doesn't include java recipe
     Failure/Error: end.converge('stack_commons::mysql_base', described_recipe)
     Chef::Exceptions::ResourceNotFound:
       resource ruby_block[Install plugin: newrelic_mysql_plugin] is configured to notify resource service[elasticsearch] with action restart, but service[elasticsearch] cannot be found in the resource collection. ruby_block[Install plugin: newrelic_mysql_plugin] is defined in /tmp/d20141031-29909-vijdor/cookbooks/elasticsearch/libraries/install_plugin.rb:35:in `install_plugin'

I think it's due to a definition called install_plugin in newrelic_plugins_chef https://github.com/newrelic-platform/newrelic_plugins_chef/blob/ba9ddd843560894494d134f67596a84ce5c4a172/definitions/install_plugin.rb, and one in elasticsearch https://github.com/elasticsearch/cookbook-elasticsearch/blob/master/libraries/install_plugin.rb#L35. so when newrelic_plugins_chef recipe is calling its definition to install a plugin, it actually triggers the elasticsearch plugin install.

I need to investigate more :-(

@jujugrrr
Copy link
Contributor Author

jujugrrr commented Nov 3, 2014

It's passing now with my fork : newrelic/newrelic_plugins_chef#29

I'm not sure it will be accepted upstream, so I'm trying to update our old rackspace_fork rackspace-cookbooks/newrelic_plugins_chef#1

@martinb3
Copy link
Contributor

martinb3 commented Nov 3, 2014

retest this please

1 similar comment
@jujugrrr
Copy link
Contributor Author

jujugrrr commented Nov 3, 2014

retest this please

@jujugrrr
Copy link
Contributor Author

jujugrrr commented Nov 3, 2014

and succeed please

@jujugrrr
Copy link
Contributor Author

jujugrrr commented Nov 3, 2014

@lmunro FYI, as you are reviewing 😉
Comments from Martin :

https://github.com/rackspace-cookbooks/stack_commons/pull/51 
I think it's okay to merge that PR on stack_commons It's long, but it's more tests than code :D

lmunro added a commit that referenced this pull request Nov 3, 2014
Add newrelic mysql plugin support to stack_commons::newrelic
@lmunro lmunro merged commit f9882d5 into master Nov 3, 2014
@lmunro lmunro deleted the newrelic branch November 3, 2014 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants