Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/use registry #385

Merged
merged 24 commits into from
Aug 11, 2023
Merged

Feature/use registry #385

merged 24 commits into from
Aug 11, 2023

Conversation

andre-merzky
Copy link
Member

This PR supports radical-cybertools/radical.pilot#2926 by removing the dependency from config files in the ZMQ bridge classes.

@andre-merzky andre-merzky self-assigned this May 7, 2023
@andre-merzky andre-merzky marked this pull request as draft May 7, 2023 21:23
@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (devel_nodb_2@402b4f8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a04cb13 differs from pull request most recent head 0cae0c1. Consider uploading reports for the commit 0cae0c1 to get more accurate results

@@               Coverage Diff               @@
##             devel_nodb_2     #385   +/-   ##
===============================================
  Coverage                ?   61.72%           
===============================================
  Files                   ?       60           
  Lines                   ?     6777           
  Branches                ?        0           
===============================================
  Hits                    ?     4183           
  Misses                  ?     2594           
  Partials                ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andre-merzky andre-merzky marked this pull request as ready for review May 15, 2023 21:11
mtitov
mtitov reviewed May 18, 2023
View reviewed changes
Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have several comments

src/radical/utils/zmq/bridge.py Show resolved Hide resolved
src/radical/utils/zmq/pubsub.py Outdated Show resolved Hide resolved
src/radical/utils/zmq/queue.py Outdated Show resolved Hide resolved
src/radical/utils/zmq/registry.py Show resolved Hide resolved
src/radical/utils/zmq/registry.py Outdated Show resolved Hide resolved
tests/unittests/test_zmq_server.py Outdated Show resolved Hide resolved
mtitov
mtitov approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mturilli
Copy link
Contributor

Apparently, we have new failures in the required tests. Do we need to fix them before merging?

@mturilli
Copy link
Contributor

Two tests failing. Need fixing before merging into nodb_2

@andre-merzky andre-merzky changed the base branch from devel to devel_nodb_2 August 10, 2023 19:50
@mturilli mturilli merged commit d39d267 into devel_nodb_2 Aug 11, 2023
1 check passed
@mturilli mturilli deleted the feature/use_registry branch August 11, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtitov mtitov mtitov approved these changes

Assignees

@andre-merzky andre-merzky

Labels
external priority:medium type:refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andre-merzky @mturilli @mtitov