-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/registry logging #414
Fix/registry logging #414
Conversation
this should *not* be documented not encouraged to be used by anybody outside of the core developer group
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #414 +/- ##
==========================================
+ Coverage 61.95% 62.18% +0.22%
==========================================
Files 62 62
Lines 6845 6899 +54
==========================================
+ Hits 4241 4290 +49
- Misses 2604 2609 +5 ☔ View full report in Codecov by Sentry. |
# NOTE: this is ignoring `RADICAL_LOG_LVL` on purpose | ||
LOG_ENABLED = os.environ.get('RADICAL_ZMQ_LOG', '0').lower() in ['1', 'true'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got confused with the necessity of introducing this.. I see that you've updated ns
for loggers (some of them were already set correctly), which makes it easy and right way to control all of this with RADICAL_UTILS_ZMQ_LOG_LVL
.
As well:
- all debug messages here are level 9, thus they will never appear for the regular debugging and controlling their appearance with the env variable above is straightforward;
- with the proposed setup it is not possible to turn off zmq-related log messages completely;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing, we can keep an explicit default value for RADICAL_UTILS_ZMQ_LOG_LVL
in DefaultConfig
(utils_default.json
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a necessity, but convenience: the ns is not consistently used, specifically when some ZMQ subscriber etc uses a 3rd party logger (such as the agent logger etc). Also, the bulk_log
method is a bit expensive even when not logging anything, so I wanted to shield zmq logging separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This makes ZMQ logging more sane to handle.