Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill process group also #424

Merged
merged 1 commit into from
Nov 1, 2024
Merged

kill process group also #424

merged 1 commit into from
Nov 1, 2024

Conversation

andre-merzky
Copy link
Member

Avoid zombification of process children

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 61.54%. Comparing base (0cb6d17) to head (15e1d30).
Report is 2 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/heartbeat.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #424      +/-   ##
==========================================
- Coverage   61.56%   61.54%   -0.02%     
==========================================
  Files          62       62              
  Lines        6972     6975       +3     
==========================================
+ Hits         4292     4293       +1     
- Misses       2680     2682       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andre-merzky andre-merzky merged commit 3e1fdd8 into devel Nov 1, 2024
11 checks passed
@andre-merzky andre-merzky deleted the fix/pwatcher_pgkill branch November 1, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants