Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image rotation #40

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Fix image rotation #40

merged 4 commits into from
Oct 10, 2024

Conversation

aknierim
Copy link
Member

@aknierim aknierim commented Oct 9, 2024

  • Fix image rotation caused by bug in rd/lm grid computation
  • Fix field order in pyvisgen.simulation.observation.ValidBaselineSubset data class
  • Flip input image at the beginning of pyvisgen.simulation.visibility.vis_loop to ensure correct indexing, e.g. for plotting

@aknierim aknierim requested a review from Kevin2 October 9, 2024 08:09
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (4978574) to head (e93ae00).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   83.80%   83.82%   +0.01%     
==========================================
  Files          13       13              
  Lines         840      841       +1     
==========================================
+ Hits          704      705       +1     
  Misses        136      136              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Kevin2 Kevin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aknierim aknierim merged commit 05c9809 into main Oct 10, 2024
6 checks passed
@aknierim aknierim deleted the fix_image_rot branch October 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants