Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam2jansky #9

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Beam2jansky #9

merged 2 commits into from
Oct 24, 2024

Conversation

aknierim
Copy link
Member

Add Jy/beam -> Jy/px image conversion

@aknierim aknierim marked this pull request as ready for review October 24, 2024 09:44
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.88%. Comparing base (180195c) to head (9fd7ded).

Files with missing lines Patch % Lines
radiotools/utils/utils.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   44.51%   44.88%   +0.37%     
==========================================
  Files          10       10              
  Lines         474      479       +5     
  Branches       54       54              
==========================================
+ Hits          211      215       +4     
- Misses        252      253       +1     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Kevin2 Kevin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kevin2
Copy link
Member

Kevin2 commented Oct 24, 2024

unit test missing :D

@aknierim
Copy link
Member Author

unit test missing :D

Will add one in another PR :D

@aknierim aknierim merged commit b95ad45 into main Oct 24, 2024
7 checks passed
@aknierim aknierim deleted the beam2jansky branch October 24, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants