Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix trade issue where items would not be sent to storage as expected.
The storage or inventory destination is included in the ACCEPT_TRADE message from the client. It was previously, only sent after the client had received acknowledgement from the server that the first accept had been received. If a player clicked the accept button the second time very quickly, before the receipt, the destination would not be included in the message. - nor would the trade log get set. This fix sends the destination information with all ACCEPT_TRADE messages, and also sets the trade log. All ACCEPT_TRADE messages always included the bytes but just did not set them unless it had had the receipt. I did try a different fix that prevented sending the second ACCEPT_TRADE message until the receipt was received, it was just overly complex due to the vast range of possible states and messages.
- Loading branch information