Added buffer pool to NIOTSConnectionChannel #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added buffer pool to NIOTSConnectionChannel for reading messages.
Motivation:
In order to avoid creating a new
ByteBufferfor every single message read from the channel, we decided to reuse thePooledRecvBufferAllocatortype fromNIOCoreto leverage a pool of buffers.Modifications:
Used the buffer allocation mechanism provided by the
PooledRecvBufferAllocatorto reuse and adapt previously created receive buffers.Result:
Channel reads can now reuse previously created buffers, avoiding unnecessary overhead by creating new buffers every single time.