Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stack keywords #470

Merged
merged 6 commits into from
Jul 29, 2023
Merged

fix stack keywords #470

merged 6 commits into from
Jul 29, 2023

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Jul 3, 2023

Closes #469

And fixes a bunch of other missing keywords. But these all need tests, which is a pain to write

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

Merging #470 (57abadf) into main (70941cd) will increase coverage by 1.29%.
Report is 3 commits behind head on main.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   81.10%   82.39%   +1.29%     
==========================================
  Files          49       49              
  Lines        4101     4481     +380     
==========================================
+ Hits         3326     3692     +366     
- Misses        775      789      +14     
Files Changed Coverage Δ
src/utils.jl 80.82% <ø> (ø)
src/stack.jl 84.37% <96.29%> (+3.24%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rafaqz rafaqz merged commit 712570b into main Jul 29, 2023
9 checks passed
@rafaqz rafaqz deleted the fix_stack_kw branch July 29, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RasterStack does not load lazily with directory path as argument
2 participants