-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main
into cf
#822
Closed
Closed
Merge main
into cf
#822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Rasters.jl export Extents.extent * Update src/Rasters.jl * Update src/Rasters.jl --------- Co-authored-by: Rafael Schouten <[email protected]>
to fix the load error
* Print a styled error message so it's more eye-catching * Mention that packages need to be loaded *manually* Co-authored-by: Rafael Schouten <[email protected]> --------- Co-authored-by: Rafael Schouten <[email protected]>
* add continue_patch commits here * fix refdims values in testts * fix Vararg warnings * bugfix concat * fix concat with parent * min bound DD at 0.28.2 * compare parents in reproject * fix comparison * bugfix comparisons * bugfix tests * fix allocs? * fix allocs * run code once before testing allocations * allow more allocations for 1.11
* optimize cellsize for lon-lat projections * never reverse order of intervalbounds * add a test with a reverse order dimension * use approx so tests pass * combine two broadcasts * change cellsize to cellarea and default to m2 * fix a test * use mapped dims if those are lon-lat * fix typo in test * remove some code scribbles * radius not R * better check if a crs is lon-lat * even better check if projection is lon-lat * define AG = ArchGDAL in main file * use sind and cosd instead of deg2rad * use isintervals(dims) * consistently use AG instead of ArchGDAL * add area_in_crs keyword * make the example easier to read * use Eriksson's formula instead of Girard's theorem * test on a 5x5m grid * get rid of accidental line in test * put back order = :trad * optimizations * depend on GeometryOpsCore, reexport common manifolds * Refactor the toplevel `cellarea` to take a method as the first arg * Remove kwargs from cellarea * Fix dispatch and propagate kwargs * Update Project.toml * fix typo * Update extensions.jl * Update Rasters.jl * fix tests * Switch `reproject` to use Proj instead of ArchGDAL This commit creates a new `reproject` method that uses Proj to transform an array of values in place using `proj_trans_generic`, only allocating a Float64 output array. It also performs the reproject check before actually transforming the array. This decreases runtime on my machine from 4.168 ms (ArchGDAL) to 665.187 μs (Proj), and allocations from 35167 allocs: 1.254 MiB (ArchGDAL) to 108 allocs: 42.859 KiB (Proj). * Fix invocations to ArchGDAL GFT converts in tests * Add `+type=crs` to all Proj-strings This is a weakness of this method compared to the old ArchGDAL method. Does this need a fix in Proj? * Implement cellarea in Proj * Add Proj to test project * Switch cellarea tests to Proj * Bump Proj compat to 1.7.2 to get the WKT support * remove cellarea and reproject.jl from archgdal extension * throw extension error with reproject Co-authored-by: Rafael Schouten <[email protected]> --------- Co-authored-by: Anshul Singhvi <[email protected]> Co-authored-by: Rafael Schouten <[email protected]>
* add missing deps * typeo
* add a constructor to load future worldclim as a rasterstack * pass keywords to raster and use bioclim keys * add a raster constructor for future bioclim * add some tests * bump rasterdatasources compat * tests need proj * use RDS 0.7 * fix a broken test --------- Co-authored-by: Rafael Schouten <[email protected]>
* Update utils.jl * Update ncdatasets_source.jl
* extract tweaks * just write kw... in docs Co-authored-by: Rafael Schouten <[email protected]> * use Type{G} Co-authored-by: Rafael Schouten <[email protected]> * add a missing where G * merge _rowtype changes from other branch * optimization for extract points with skipmissing --------- Co-authored-by: Rafael Schouten <[email protected]>
* Update commondatamodel.jl * Add test * move resample tests to be last * Include commondatamodel and zarr tests * use Zarr from ZarrDatasets.jl * Don't run Zarr tests * Add the julia cache action to speed up CI
* extract tweaks * add rasters.sample * get rid of some toy code * just write kw... in docs Co-authored-by: Rafael Schouten <[email protected]> * use Type{G} Co-authored-by: Rafael Schouten <[email protected]> * add a missing where G * neater formatting * better reuse _rowtypes code * more code style Co-authored-by: Rafael Schouten <[email protected]> * extract tweaks * add rasters.sample * get rid of some toy code * neater formatting * better reuse _rowtypes code * more code style Co-authored-by: Rafael Schouten <[email protected]> * merge _rowtype changes from other branch * optimization for extract points with skipmissing * streamline _rowtype * correctly use _rowtype * improve type stability * switch to using dimindices internally * let users specify geometry type * just use a broadcast * don't need to be compatible with julia < 1.9 Co-authored-by: Rafael Schouten <[email protected]> * deal with type stability better * allow not providing `n` * tweak the docstring --------- Co-authored-by: Rafael Schouten <[email protected]>
* bugfix * add tests
Look weird, I will rebase instead |
Ah yeah that diff is strange...did this locally and diff looked ok ish there. Rebase is probably better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.