Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp: Tidy up the RaidenService module and introduce some structure #2147

Closed
weilbith opened this issue Sep 21, 2020 · 1 comment
Closed

Comments

@weilbith
Copy link
Contributor

weilbith commented Sep 21, 2020

Description

At the moment this module is a steadily growing. Functions get bigger and bigger. Nobody finds something, it is hard to read and hard to extend. Parts like the subscription to events for submitting notifications started small for a couple of events. Now it has become huge without any structure. But actually this procedure follows a pretty simple schema. This should be represented in the code. This will increase the readability of the code and new contributor can easily add/remove a notification.
Another example is the connect() function. It is at the moment of writing 167 (!!!!!) lines long. This is insane. Everybody add something somewhere. There is no structure of the code and no overview what happens during this stage of the application.
This story continues...
Although is the concept of separating concerns missing. This makes it incredibly hard to have good tests and especially an overview of how complete/good the test suite(s) is/are.

Acceptance criteria

  • The code is clean, readable and easy to extend

Tasks

  • [ ]
@taleldayekh
Copy link
Contributor

Closing, already an issue for this #2231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants