Skip to content

Commit

Permalink
Unsticky "Appears in" element from bottom of page
Browse files Browse the repository at this point in the history
Stickying the "Appears in" `<details>` at the bottom of the page causes
the element to jump up when it is expanded, which is unexpected and
unusual.  Since the element already hides information by default, there
is no need to force it to stay all the way at the bottom of the page.
This commit removes the sticky positioning and fixes some
inconsistencies in the grid definition.
  • Loading branch information
jonathanhefner committed Aug 5, 2023
1 parent 123a26f commit e2e8fa5
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions lib/rdoc/generator/template/rails/resources/css/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -10,50 +10,48 @@ body {
line-height: 1.25em;
min-height: 100%;
display: grid;
grid-template-rows: min-content min-content auto min-content;
grid-template-columns: 300px auto;

--link-color: #CC0000;
--link-hover-color: #990000;
--icon-color: #777777;
}

body {
grid-template-rows: min-content min-content auto min-content;
grid-template-rows: min-content min-content min-content;
grid-template-columns: 100%;
}

@media (min-width: 600px) {
body {
grid-template-rows: min-content min-content auto min-content;
grid-template-rows: min-content min-content min-content;
grid-template-columns: 300px auto;
}

nav {
grid-row-start: 1;
grid-row-end: 4;
grid-row-end: 3;
grid-column-start: 1;
grid-column-end: 1;
}

div.banner {
grid-row-start: 2;
grid-row-end: 2;
grid-row-start: 1;
grid-row-end: 1;
grid-column-start: 2;
grid-column-end: 2;
}

#bodyContent {
grid-row-start: 3;
grid-row-end: 3;
grid-row-start: 2;
grid-row-end: 2;
grid-column-start: 2;
grid-column-end: 2;
min-width: 0;
}

footer {
grid-row-start: 4;
grid-row-end: 4;
grid-row-start: 3;
grid-row-end: 3;
grid-column-start: 2;
grid-column-end: 2;
}
Expand Down

0 comments on commit e2e8fa5

Please sign in to comment.