Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate project_version and badge_version #271

Commits on Aug 5, 2023

  1. Consolidate project_version and badge_version

    Since 5042d1e, the value of
    `ENV["HORO_BADGE_VERSION"]` is preferred over the value of
    `ENV["HORO_PROJECT_VERSION"]`.  Therefore, we can consolidate the
    `project_version` and `badge_version` helpers.
    
    Note that while `ENV["HORO_BADGE_VERSION"]` has the format we desire,
    `ENV["HORO_PROJECT_VERSION"]` is the more obvious and preferable name.
    After these changes is released, we can encourage consumers (namely,
    Rails) to set `ENV["HORO_PROJECT_VERSION"]` with the same value as
    `ENV["HORO_BADGE_VERSION"]` and then to drop `ENV["HORO_BADGE_VERSION"]`
    altogether.
    jonathanhefner committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    c76d02e View commit details
    Browse the repository at this point in the history