Prevent git commands if project is not a git repo #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, git commands (such as the command to get `remote.origin.url`) would always be run if git was installed. This caused "fatal: not a git repository" to be printed to `stderr` when the project was not a git repository. This commit modifies `SDoc::Helpers::Git#git?` such that git commands will only be run if git is installed _and_ the project is a git repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, git commands (such as the command to get
remote.origin.url) would always be run if git was installed. This caused "fatal: not a git repository" to be printed tostderrwhen the project was not a git repository.This commit modifies
SDoc::Helpers::Git#git?such that git commands will only be run if git is installed and the project is a git repository.