Extract basic :call-seq: params for search results
#353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, search results displayed `(...)` as the parameter list for any `:call-seq:` method. The reason being the `:call-seq:` value may contain method overloads (i.e. multiple parameter lists) or even arbitrary text. However, it is common for the `:call-seq:` value to be basic method signature with a single parameter list. Therefore, this commit handles that case and otherwise falls back to `(...)`.
jonathanhefner
force-pushed
the
search-results-call-seq-params
branch
from
017dfe5
to
eb7b1fc
Compare
jonathanhefner
changed the title
:call-seq: params for search index:call-seq: params for search results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, search results displayed
(...)as the parameter list for any:call-seq:method. The reason being the:call-seq:value may contain method overloads (i.e. multiple parameter lists) or even arbitrary text. However, it is common for the:call-seq:value to be basic method signature with a single parameter list. Therefore, this commit handles that case and otherwise falls back to(...).