Fix performance regression due to git calls #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In d08ca4d, an isolated scope was created for each rendered file. That inadvertently reset memoized values from `git` calls for each file, causing a performance regression. This commit fixes the regression by memoizing the values globally. With d08ca4d~1 (444c4a4): ```console $ time bundle exec rake test:rails real 0m31.567s user 0m31.159s sys 0m0.394s ``` With d08ca4d: ```console $ time bundle exec rake test:rails real 1m11.195s user 1m2.671s sys 0m8.811s ``` With d08ca4d + this commit (retrofitted): ```console $ time bundle exec rake test:rails real 0m26.155s user 0m25.796s sys 0m0.331s ``` With `main`: ```console $ time bundle exec rake test:rails real 1m16.000s user 1m7.478s sys 0m8.818s ``` With `main` + this commit: ```console $ time bundle exec rake test:rails real 0m29.964s user 0m29.562s sys 0m0.399s ``` Fixes rails#361.
|
Thanks @jonathanhefner ! |
p8
added a commit
to p8/rails
that referenced
this pull request
Jan 22, 2024
The latest version of SDoc fixes a performance regression. This version is at least twice as fast. rails/sdoc#363
4 tasks
viralpraxis
pushed a commit
to viralpraxis/rails
that referenced
this pull request
Mar 24, 2024
The latest version of SDoc fixes a performance regression. This version is at least twice as fast. rails/sdoc#363
fractaledmind
pushed a commit
to fractaledmind/rails
that referenced
this pull request
May 13, 2024
The latest version of SDoc fixes a performance regression. This version is at least twice as fast. rails/sdoc#363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In d08ca4d, an isolated scope was created for each rendered file. That inadvertently reset memoized values from
gitcalls for each file, causing a performance regression.This commit fixes the regression by memoizing the values globally.
With d08ca4d~1 (444c4a4):
With d08ca4d:
With d08ca4d + this commit (retrofitted):
With
main:With
main+ this commit:Fixes #361.