Support CICD #477
Merged
Support CICD #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, can we make a release after this PR is merged? We had docker image ready for almost 3 months now and it's still not published |
aleksrutins
approved these changes
Feb 2, 2024
coffee-cup
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADMIN NOTE: This flag is now
--ci(#490)Support CICD deploys by staying until the build stage is complete and reporting it's result in exit code
Changes:
upcommand argument:cicdWhen this argument is provided, cli won't stream deploy logs and will exit immediately after deploy status changes to
SUCCESS.This required changing
wait_for_failurefunction to support this case. In both of them it will cause the cli to exit with either error exit code or zero, which would indicate success.