Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i686-pc-windows-gnu target build #479

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Fix i686-pc-windows-gnu target build #479

merged 2 commits into from
Feb 20, 2024

Conversation

maddsua
Copy link
Contributor

@maddsua maddsua commented Jan 30, 2024

This PR fixes occasional railway cli install errors.

Related help threads:
https://discord.com/channels/713503345364697088/1196823606320185445
https://discord.com/channels/713503345364697088/1194757540693671978

Related issues:
#454
#428

The i686-pc-windows-gnu target does not compile on windows image for whatever reason, but we can cross compile it instead.

Changes:

  • Updated build image for the target
  • Disabled continue-on-error option

Build result is tested on my machine, don't see any issues with functionality.

@maddsua maddsua marked this pull request as ready for review January 30, 2024 20:07
@maddsua maddsua changed the title Fix i686 windows target build Fix i686-pc-windows-gnu target build Jan 30, 2024
@Milo123459 Milo123459 added the release/skip Author no release label Feb 15, 2024
@zuchka zuchka merged commit 1dad2e9 into railwayapp:master Feb 20, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/skip Author no release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants