-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .node-version file basic support #1235
Add .node-version file basic support #1235
Conversation
Just a small question, when I run :
I got this error... It's not breaking the tests but its weird, do you have any idea ? Details
|
Check out some of the commands in the makefile to get better errors, the default errors from running rust tests are not great |
The error is happening because there are no prebuilt binaries for Node 14 because it is such an old version and it is attempting to build it from source and there are missing dependencies needed. Using a newer version of Node should work. |
Hey @coffee-cup, I've updated the PR
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
This pull request was closed for lack of activity. Feel free to reopen later. |
Noticed that the
.node-version
convention is not currently supported.Note
This is my first Rust PR, if you have suggestion, tips or remarks 😉