Add networkStore and runtime support for networks #1835
Conversation
…nd lots of clean up
…ctionality to hold all network data
| @@ -60,17 +60,20 @@ export const estimateSwapGasLimit = async ({ | |||
| const provider = getProvider({ chainId }); | |||
|
|
|||
| if (!provider || !quote) { | |||
| return getChainGasUnits(chainId).basic.swap; | |||
| const chainGasUnits = networkStore.getState().getChainGasUnits(chainId); | |||
There was a problem hiding this comment.
can pull this line out to line 61 and delete the duplicate line on 72
There was a problem hiding this comment.
Can, but only wanted to grab it when/if we needed to in order to reduce calls to the network store.
walmat
requested review from
DanielSinclair,
christianbaroni,
derHowie and
BrodyHughes
| balance: { amount: '', display: '' }, | ||
| chainId: chainId, | ||
| chainName: chainsLabel[chainId] as ChainName, | ||
| chainName: chainLabel as ChainName, |
There was a problem hiding this comment.
this looks like an existing issue, but chainName should be from getChainsName instead of getChainsLabel to be consistent
There was a problem hiding this comment.
also existing issue: on line 46 it looks like we are including native_asset_ in the uniqueId which seems inconsistent with the way we handle uniqueIds
| @@ -358,7 +358,7 @@ it('should be able to open token to buy input and select assets', async () => { | |||
| expect(toBuyInputDaiSelected).toBeTruthy(); | |||
| }); | |||
|
|
|||
| it('should be able to type native amount on sell input', async () => { | |||
| it.skip('should be able to type native amount on sell input', async () => { | |||
There was a problem hiding this comment.
Can you provide any info on this one? I can make a ticket but making sure this was intentional.
There was a problem hiding this comment.
so for context: this failure has been happening since my PR was merged (#1830). I think something with the quotes changed and I need to fix it. I recommended skipping this for now so we have an actual working e2e in the meantime.
| "anvil": "anvil --fork-url $(./scripts/get-rpc-url.sh mainnet) --fork-block-number 21574102 --block-base-fee-per-gas 5000000000 --block-gas-limit 30000000", | ||
| "anvil": "anvil --fork-url $(./scripts/get-rpc-url.sh mainnet) --fork-block-number 21574102 --block-base-fee-per-gas 1000000000 --block-gas-limit 30000000", |
There was a problem hiding this comment.
Did this have a material effect on e2e?
There was a problem hiding this comment.
Yes it did. Bruno actually recommended it a few weeks ago if we saw more of a specific failure type which matthew was seeing. Again, i recommended this and it did fix an issue.
Fixes BX-1740, BX-1742, BX-1741, BX-1739, BX-1675
What changed (plus any additional context for devs)
backendNetworksandcustomNetworkscustomNetworksnow powers the pre-populated list of custom chains a user can addcreateQueryStorearchitecturenetworkStorethat merges pre-existinguserChainsandrainbowChainsstores togethercreateSelectorandcreateParameterizedSelectornetworkStorestore methodsreferences/chainsfile with static build time accessorsScreen recordings / screenshots
// will try and capture a few screenshots tonight
What to test
https://www.notion.so/rainbowdotme/NetworkStore-Detailed-Test-Checklist-19eb001b85b48074a134d0ca093dbb9b