-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sematic/lexcial search feature in datagateway search #1527
Draft
kennethnym
wants to merge
17
commits into
develop
Choose a base branch
from
feature/semantic-search
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethnym
added
enhancement
New feature or request
datagateway-search
Issues relating to the search plugin
labels
May 18, 2023
cc @saifulkhan |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1527 +/- ##
===========================================
- Coverage 96.20% 95.78% -0.43%
===========================================
Files 161 164 +3
Lines 6885 6975 +90
Branches 2139 2154 +15
===========================================
+ Hits 6624 6681 +57
- Misses 240 273 +33
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
# Conflicts: # packages/datagateway-dataview/src/views/card/isis/isisDataPublicationsCardView.component.test.tsx # packages/datagateway-dataview/src/views/table/isis/isisStudiesTable.component.test.tsx
The new v2 ML API now supports lexical support. A new dropdown is added to let user choose between 3 search modes: Lucene, semantic, and lexical.
kennethnym
changed the title
Implement sematic search feature in datagateway search
Implement sematic/lexcial search feature in datagateway search
Aug 25, 2023
- Fix search not working when Lucene search mode selected - Update tests to reflect URL params chhanges
New searchType param is added, so the expected value needs to be updated
Updated demo video to reflect the new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a dropdown that lets the user choose to search with either Lucene or the new ML API, which provides endpoints for performing semantic/lexical search. The ML API utilizes OpenSearch and LLM to perform search operations.
DataGateway.Search.and.8.more.pages.-.Work.-.Microsoft.Edge.2023-08-31.17-47-19.mp4
n_top_results
)Please feel free to suggest changes to the UI.
cc @agbeltran
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #1526