Mint custom datapublications #1529 #1531 #1537

louise-davies · 2023-06-14T08:34:54Z

Description

Adds a button to the cart page which lets the user mint their selection if they have permission, and once clicked it takes them to an "accept data policy page", which then accepting takes them to the generate DOI form. Once the user has filled out the required fields, they can generate a DOI, which once it is minted will cause a popup to appear with the DOI and a button to take the user to the landing page. See screenshots of the generate DOI page (names and emails redacted in the screenshots since it's based on real users)

Testing instructions

Add a set up instructions describing how the reviewer should test the code

Review code
Check Actions build
Review changes to test coverage
Deploy with other PR & Alex's minting backend to test the DOI minting workflow

Agile board tracking

Closes #1529, Closes #1531

…han the current user

I've mocked the backend for now - might need to adjust the querying code when it gets implemented

also do some prep for generate DOI functionality

also add loading spinner to user table and disable generate DOI button when requirements aren't met

…efault

also rejig the form to overflow better

also rejig the overflow UI of the DOI generation form

also, turn accept data policy form back on and add a TODO and better placeholder text

an update to the API meant empty arrays error

also fix some errors in testing error codes

also improve downloadTab tests

codecov · 2023-07-06T12:07:36Z

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4a7132f) 96.21% compared to head (ae1fb81) 96.16%.
Report is 6 commits behind head on develop.

Files	Patch %	Lines
packages/datagateway-download/src/downloadApi.ts	93.82%	5 Missing ⚠️
...ad/src/DOIGenerationForm/relatedDOIs.component.tsx	94.00%	2 Missing and 1 partial ⚠️
.../DOIGenerationForm/DOIGenerationForm.component.tsx	97.10%	1 Missing and 1 partial ⚠️
...nerationForm/creatorsAndContributors.component.tsx	96.96%	2 Missing ⚠️
...kages/datagateway-download/src/downloadApiHooks.ts	97.26%	2 Missing ⚠️
packages/datagateway-download/src/App.tsx	0.00%	1 Missing ⚠️
...c/DOIGenerationForm/DOIConfirmDialog.component.tsx	97.14%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1537      +/-   ##
===========================================
- Coverage    96.21%   96.16%   -0.06%     
===========================================
  Files          165      170       +5     
  Lines         7089     7485     +396     
  Branches      2218     2378     +160     
===========================================
+ Hits          6821     7198     +377     
- Misses         247      266      +19     
  Partials        21       21

Flag	Coverage Δ
common	`95.61% <100.00%> (-0.01%)`	⬇️
dataview	`96.95% <ø> (ø)`
download	`95.83% <96.02%> (-0.21%)`	⬇️
search	`96.47% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- This fixes infinite scrolling when a sort or filter other than the default is applied

…#1531

…s for related DOIs

louise-davies · 2023-11-02T12:02:45Z

@patrick-austin I have added the functionality for Contributors & Related DOIs based off our previous conversation & the wireframes I mocked up:

…t users haven't loaded yet

…#1531

louise-davies · 2024-01-15T09:56:10Z

@kaperoo For testing, you will need to add the following new urls to the download settings json

"doiMinterUrl": "https://scigateway-preprod.esc.rl.ac.uk/doi-minter",
"dataCiteUrl": "https://api.test.datacite.org",

kaperoo · 2024-01-15T14:26:31Z

packages/datagateway-dataview/cypress/e2e/card/dls/datasets.cy.ts

@@ -109,7 +109,7 @@ describe('DLS - Datasets Cards', () => {
    cy.get('[data-testid="card"]').first().contains('DATASET 61');
  });

-  it('should be able to filter by multiple fields', () => {
+  it.only('should be able to filter by multiple fields', () => {


remove .only

kaperoo · 2024-01-15T14:30:50Z

packages/datagateway-download/src/downloadCart/downloadCartTable.component.tsx

Shouldn't there be const settings = React.useContext(DownloadSettingsContext); somewhere in DownloadCartTable component?

Yep, I think it got obliterated in the merge resolution

kaperoo

Looks good but I think settings need to be defined in the DownloadCartTable component to fix testing errors.

…er is entered

louise-davies added 15 commits May 25, 2023 09:22

#1529 - add generate DOI button that checks ismintable

6457580

#1529 #1531 add basic DOI form and link it from the cart

aafb082

#1531 - fetch list of users for every item in the cart

63b2a43

#1531 - add selected user table & allow for deletion of users other t…

30d8b3c

…han the current user

#1531 - improve acceptDataPolicy look

f8fb7b8

#1531 - implement add users ability

cdd334a

I've mocked the backend for now - might need to adjust the querying code when it gets implemented

#1531 - connect check user functionality to backend properly

ee6f393

also do some prep for generate DOI functionality

#1531 - add simple summary table

962a19c

also add loading spinner to user table and disable generate DOI button when requirements aren't met

#1529 - Fix typo that prevented single item carts from being minted

16c811c

#1531 - hide cart tabs that are empty and select a non-empty one by d…

7c54914

…efault

#1531 - add mint DOI functionality

be61457

also rejig the form to overflow better

#1531 - add DOI confirmation dialogue

e0b8e7d

also rejig the overflow UI of the DOI generation form

#1531 - change email to username in DOI creators stuff

2bcd899

#1531 - prevent mint DOI page from being accessed directly

aaa1940

also, turn accept data policy form back on and add a TODO and better placeholder text

#1531 - improve layout on larger screens

43fd8b6

louise-davies requested a review from moonraker595 June 14, 2023 08:34

louise-davies added 10 commits June 23, 2023 14:24

Fix dark mode issues with buttons & tabs

8f26a07

#1531 - fix a few more dark mode things

78d9404

#1529 #1531 - don't pass empty arrays to minting API

7bdc362

an update to the API meant empty arrays error

#1529 - highlight which rows a user doesn't have permission to mint

47cb969

also fix some errors in testing error codes

Fix table row hover

2809289

#1529 - improve hover detection for row highlighting

e45c51a

#1529 #1531 - extract strings to translation file

ebc33d5

#1529 #1531 - fix broken unit tests

f339c61

#1529 #1531 - add unit tests for minting api hooks

3f0a920

#1291 - add tests for mint cart button

591f818

also improve downloadTab tests

louise-davies added 3 commits July 7, 2023 14:23

#1531 - add tests for DOIGenerationForm

701b742

#1531 - add DOIConfirmDialog tests

77ced80

#1531 - fix names of tests & decrease characters typed

ffe241b

louise-davies added 8 commits October 24, 2023 14:22

#1531 - fix CI by changing topcat to datagateway-download-api

0b09966

Add initialQueryOffset to admin downloads query key

2c06af2

- This fixes infinite scrolling when a sort or filter other than the default is applied

Fix CI build

8696948

Merge branch 'develop' into feature/mint-custom-datapublications-#1529-…

5ff4cfe

…#1531

#1531 add related items functionality

59392b3

#1531 - extract out users & related dois components & write unit test…

674f00c

…s for related DOIs

#1531 - add e2e test for related DOIs

32f4ab6

#1531 - render related DOIs as links + show title on hover

ab61bd3

louise-davies added 4 commits November 2, 2023 12:03

#1531 - set minWidths for selects & disable add user buttons when car…

d133ba8

…t users haven't loaded yet

#1531 - fix some tests

0fa5ed4

Increase Jest timeouts

7d6e862

Merge branch 'develop' into feature/mint-custom-datapublications-#1529-…

b04e9a0

…#1531

louise-davies removed the WIP This PR is still being worked on and should not merged label Jan 15, 2024

louise-davies requested a review from kaperoo January 15, 2024 09:55

kaperoo reviewed Jan 15, 2024

View reviewed changes

louise-davies added 4 commits January 17, 2024 10:54

Remove .only from test & fix settings context declaration

959e853

#1529 #1531 - fix how we send entity IDs to minter DOI

f59f3b8

#1531 fix test error by updating api error message when an invalid us…

93796b0

…er is entered

Fix casing

ae1fb81

louise-davies requested a review from kaperoo January 17, 2024 17:13

kaperoo approved these changes Jan 18, 2024

View reviewed changes

louise-davies merged commit 10bb7d1 into develop Jan 18, 2024
10 checks passed

louise-davies deleted the feature/mint-custom-datapublications-#1529-#1531 branch January 18, 2024 09:44

louise-davies added enhancement New feature or request datagateway-download Issues relating to the download plugin user feedback Issues that were raised by users labels Jan 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mint custom datapublications #1529 #1531 #1537

Mint custom datapublications #1529 #1531 #1537

louise-davies commented Jun 14, 2023 •

edited

Loading

codecov bot commented Jul 6, 2023 •

edited

Loading

louise-davies commented Nov 2, 2023

louise-davies commented Jan 15, 2024

kaperoo Jan 15, 2024

kaperoo Jan 15, 2024

louise-davies Jan 17, 2024

kaperoo left a comment

Mint custom datapublications #1529 #1531 #1537

Mint custom datapublications #1529 #1531 #1537

Conversation

louise-davies commented Jun 14, 2023 • edited Loading

Description

Testing instructions

Agile board tracking

codecov bot commented Jul 6, 2023 • edited Loading

Codecov Report

louise-davies commented Nov 2, 2023

louise-davies commented Jan 15, 2024

kaperoo Jan 15, 2024

Choose a reason for hiding this comment

kaperoo Jan 15, 2024

Choose a reason for hiding this comment

louise-davies Jan 17, 2024

Choose a reason for hiding this comment

kaperoo left a comment

Choose a reason for hiding this comment

louise-davies commented Jun 14, 2023 •

edited

Loading

codecov bot commented Jul 6, 2023 •

edited

Loading