Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve sorting ux #1541 #1578

Merged
merged 25 commits into from
Oct 25, 2023
Merged

Feature/improve sorting ux #1541 #1578

merged 25 commits into from
Oct 25, 2023

Commits on Sep 1, 2023

  1. Added shift+click sorting #1541

    @kaperoo
    kaperoo committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    70a8178 View commit details
    Browse the repository at this point in the history

  2. Code cleanup #1541

    @kaperoo
    kaperoo committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    d1294dd View commit details
    Browse the repository at this point in the history

  3. Sorting unit test fix #1541

    @kaperoo
    kaperoo committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    88d2702 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Shift-click sorting for download tables #1541

    @kaperoo
    kaperoo committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    a28a6bd View commit details
    Browse the repository at this point in the history

  2. Fixed sorting in card view #1541

    @kaperoo
    kaperoo committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    e03740d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. changed the way shift is passed to onSort #1541

    @kaperoo
    kaperoo committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    374c857 View commit details
    Browse the repository at this point in the history

  2. Fix issues with download e2e tests #1541

    @kaperoo
    kaperoo committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0586bd4 View commit details
    Browse the repository at this point in the history

  3. changed the way shiftDown is passed in cardview #1541

    @kaperoo
    kaperoo committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    ca20c22 View commit details
    Browse the repository at this point in the history

  4. fix to the single column sort test in admin download #1541

    @kaperoo
    kaperoo committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    52d0395 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Fixed dataview e2e tests #1541

    @kaperoo
    kaperoo committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    72be066 View commit details
    Browse the repository at this point in the history

  2. Fix dataview e2e tests 2 #1541

    @kaperoo
    kaperoo committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e94c94a View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Improved code coverage #1541

    @kaperoo
    kaperoo committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    76f26b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Merge branch 'develop' into feature/improve-sorting-ux-#1541

    @kaperoo
    kaperoo committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f86c192 View commit details
    Browse the repository at this point in the history

  2. Adjusted + added e2e tests for multiple column sorting #1541

    @kaperoo
    kaperoo committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    79e4336 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. fix e2e test for adminDownloadDtatus #1541

    @kaperoo
    kaperoo committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    77f3972 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/improve-sorting-ux-#1541

    @kaperoo
    kaperoo committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c6bd356 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Reduce code repetition

    @kaperoo
    kaperoo committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    be9ef8b View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. add hover tooltips to sort indicators

    @kaperoo
    kaperoo committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c9162f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Hopefully fixed failing tests

    @kaperoo
    kaperoo committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7553763 View commit details
    Browse the repository at this point in the history

  2. updated snapshots

    @kaperoo
    kaperoo committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7492fb3 View commit details
    Browse the repository at this point in the history

  3. fix failing e2e test

    @kaperoo
    kaperoo committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    95cf7fc View commit details
    Browse the repository at this point in the history

  4. #1541 - use skipHover to avoid triggering sort tooltips in long tests 

    The tooltips appearing slow the tests down so that they risk timing out
    @louise-davies
    louise-davies committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b6bca39 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/improve-sorting-ux-#1541' of https://github.com… 

    …/ral-facilities/datagateway into feature/improve-sorting-ux-#1541
    @louise-davies
    louise-davies committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0043575 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. use skipHover to fix another test #1541

    @kaperoo
    kaperoo committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    7fe8811 View commit details
    Browse the repository at this point in the history

  2. #1541 - add delay null to downloadStatusTable userEvent 

    tests keep timing out so this might help?
    @louise-davies
    louise-davies committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    848d799 View commit details
    Browse the repository at this point in the history