Fix Data Publications e2e Test #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is to test whether the data publications e2e test has been fixed by the changes in the generator script
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1580 +/- ##
========================================
Coverage 96.20% 96.20%
========================================
Files 161 161
Lines 6885 6885
Branches 2139 2139
========================================
Hits 6624 6624
Misses 240 240
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
All the CI has passed so once ral-facilities/datagateway-api#444 has been merged, I'll change the CI references for DG API back to a pinned version (the one containing the changes in that PR). I can merge this PR and re-generate the data on SG preprod |
louise-davies
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the e2e test for ISIS data publications in table view as part of the resolution to ral-facilities/datagateway-api#444. I've pretty much just reverted the test to what it used to be - if there's specific things that need to be tested/asserted, let me know and I can make those changes.
I've checked the test against my new local generated data but I've also changed the CI to use the DG API branch that has the fix to the generator script.
Testing instructions
Agile board tracking
connect to #{issue number}