Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookie policy #1089

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

louise-davies
Copy link
Member

Description

We now have more first party cookies/local storage items, and to make it easier to maintain I'm using an array in the translation file to manage the list of essential cookies/local storage items.

I also removed the references to TopCAT & added a line that the site won't work if you block cookies at the browser level etc.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Part of #98

- plus remove TopCAT refs & update the policy a bit
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1089 (5988488) into develop (9d5c7a5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1089      +/-   ##
===========================================
+ Coverage    97.95%   97.97%   +0.01%     
===========================================
  Files           42       42              
  Lines         1565     1578      +13     
  Branches       420      422       +2     
===========================================
+ Hits          1533     1546      +13     
  Misses          31       31              
  Partials         1        1              
Impacted Files Coverage Δ
src/cookieConsent/cookiesPage.component.tsx 100.00% <100.00%> (ø)
src/state/scigateway.types.tsx 100.00% <0.00%> (ø)
src/state/reducers/scigateway.reducer.tsx 100.00% <0.00%> (ø)
src/state/middleware/scigateway.middleware.tsx 93.23% <0.00%> (ø)
src/state/actions/scigateway.actions.tsx 98.18% <0.00%> (+0.03%) ⬆️
src/theming.tsx 97.05% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5c7a5...5988488. Read the comment docs.

Copy link
Contributor

@sam-glendenning sam-glendenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made a couple of tiny changes that I think improve the wording a little but apart from that I'm happy with it. Best wait on Alejandra for her thoughts though

@louise-davies
Copy link
Member Author

I just confirmed with Alejandra re: these changes in our catchup so I'll go ahead and merge them

@louise-davies louise-davies merged commit aa684bb into develop Jun 13, 2022
@louise-davies louise-davies added the documentation Improvements or additions to documentation label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants