Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from CRA to Vite #1379 #1380

Draft
wants to merge 29 commits into
base: react-18-#1205
Choose a base branch
from

Conversation

joelvdavies
Copy link
Contributor

@joelvdavies joelvdavies commented Mar 12, 2024

Description

Replaces CRA with Vite. Used the default settings that create-vite would have generated in the tsconfig. The only real change caused by that is a requirement of underscores on some unused variable & I removed the props on the footer as they weren't either (noUnusedParameters).

Draft as should not be merged until #1275 is.

Notes

Warning

The index.html has moved out of the public folder into the root, so docker-ims needs to be updated on gitlab as the title can no longer be replaced as it used to be, and instead will be in /dist after being built. Likely also effects any ansible config.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #1379

@joelvdavies joelvdavies added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 12, 2024
@joelvdavies joelvdavies self-assigned this Mar 14, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.42%. Comparing base (b51eecf) to head (bf9dce6).

Files Patch % Lines
src/i18n.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           react-18-#1205    #1380       +/-   ##
===================================================
- Coverage           96.76%   86.42%   -10.35%     
===================================================
  Files                  48       56        +8     
  Lines                1763     8561     +6798     
  Branches              497      893      +396     
===================================================
+ Hits                 1706     7399     +5693     
- Misses                 53     1155     +1102     
- Partials                4        7        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.62%. Comparing base (5f9dbde) to head (5923c81).

Files with missing lines Patch % Lines
src/i18n.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           react-18-#1205    #1380      +/-   ##
==================================================
+ Coverage           96.95%   97.62%   +0.66%     
==================================================
  Files                  49       54       +5     
  Lines                1775     5775    +4000     
  Branches              497      896     +399     
==================================================
+ Hits                 1721     5638    +3917     
- Misses                 50      134      +84     
+ Partials                4        3       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants