Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ims maintenance endpoints #1398

Merged
merged 12 commits into from
Jul 3, 2024
Merged

Ims maintenance endpoints #1398

merged 12 commits into from
Jul 3, 2024

Conversation

MatteoGuarnaccia5
Copy link

Description

see ral-facilities/ldap-jwt-auth#88

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage

@MatteoGuarnaccia5 MatteoGuarnaccia5 changed the base branch from develop to react-18-#1205 June 20, 2024 13:42
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (a20de6e) to head (77f72e7).

Additional details and impacted files
@@                Coverage Diff                 @@
##           react-18-#1205    #1398      +/-   ##
==================================================
+ Coverage           96.93%   96.95%   +0.02%     
==================================================
  Files                  48       49       +1     
  Lines                1760     1775      +15     
  Branches              496      491       -5     
==================================================
+ Hits                 1706     1721      +15     
  Misses                 50       50              
  Partials                4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments, works with ral-facilities/ldap-jwt-auth#96 though.

src/authentication/ldapjwtAuthProvider.test.tsx Outdated Show resolved Hide resolved
src/authentication/ldapjwtAuthProvider.tsx Outdated Show resolved Hide resolved
src/state/reducers/scigateway.reducer.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this at the same time as the ldap-jwt-auth PR and docker-ims MR.

@VKTB VKTB merged commit f0c6d18 into react-18-#1205 Jul 3, 2024
4 checks passed
@VKTB VKTB deleted the ims-maintenance-endpoints branch July 3, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants