Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for OKx, rabby, taho #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naomiHauret
Copy link
Contributor

Description

This PR adds support for a number of new wallets to make it easier for people to use Rally.

  • deps: update dependencies (rainbowkit, wagmi)
  • feat: add support for the following wallets in rainbowkit : okx, safe, taho, rabby, phantom, rainbow, metamask, coinbase...

Screenshot_20230531_140801

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested ? (optional - remove if not necessary)

  1. Click on "Connect wallet"
  2. The connect wallet modal should open and display the following list of wallets in a category called "Suggested": MetaMask, Rainbow, Phantom, Taho, Rabby, OKx Wallet, Coinbase wallet
  3. Click on your wallet of choice
  4. A "Verify your account" modal should appear
  5. Click on "Send message"
  6. A message should appear in your wallet
  7. Sign this message
  8. Once verified and connected, you should be able to see the "Join your friends on Lens!" banner
  9. Click on "Sign-in with Lens"
  10. A message should appear in your wallet
  11. Sign this message
  12. You're now fully connected

Other scenarios tested

  • Create a rally
  • Update a rally
  • Join a rally
  • Leave a rally
  • Participate during a rally (mic, join stage, kick from stage, kick from rally)
  • Delete a rally

@naomiHauret naomiHauret added the enhancement New feature or request label May 31, 2023
@naomiHauret naomiHauret self-assigned this May 31, 2023
Copy link
Contributor

@timotejGerzelj timotejGerzelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants