Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

V3.0 #113

Closed
wants to merge 26 commits into from
Closed

V3.0 #113

wants to merge 26 commits into from

Conversation

InfopactMLoos
Copy link
Contributor

I have done a first implementation of types and their validations. Please review the changes and create a new branch (v3.0?) for this request, as was discussed in Issue 108. It is a working in progress for the entire 1.0 specification but for my use case it already works. I have made a quick shortlist of things we should add for a complete 1.0 release in the README. Also we can probably use more unit tests.

Also @AnzeDspot, @therealgambo

@coveralls
Copy link

coveralls commented Apr 13, 2017

Coverage Status

Coverage decreased (-18.3%) to 70.892% when pulling 3e74f20 on InfopactMLoos:v3.0 into 2f85b8d on alecsammon:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-18.3%) to 70.892% when pulling 3e74f20 on InfopactMLoos:v3.0 into 2f85b8d on alecsammon:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-18.3%) to 70.892% when pulling 3e74f20 on InfopactMLoos:v3.0 into 2f85b8d on alecsammon:master.

@therealgambo
Copy link

@InfopactMLoos , Sorry for the late reply. I'll have a look at this hopefully within the next day or so.

As for whether this eventually gets merged, I'm unsure as it looks like @alecsammon is rather inactive at the moment. I'll be happy to install directly from your fork, assuming it is tagged correctly and won't go away anytime soon :)

@martin-georgiev
Copy link
Collaborator

@InfopactMLoos can you estimate how much work will be needed to implement the remaining bits from RAML 1.0 specification based on this MR? I think there is a momentum so this can be pushed forward.

@goodevilgenius
Copy link

What's the status of this? I'd like to use this library, but I'm only use RAML 1.0.

This PR was opened over a year ago, and there's been no update on this at all.

@therealgambo
Copy link

I don't think anything is being merged at the moment. You should read over this issue: https://github.com/alecsammon/php-raml-parser/issues/117

The eLama fork is more inline with the 1.0 spec than this.

@martin-georgiev
Copy link
Collaborator

The @Elama 's fork with RAML 1.0 support is now backported to master. There is a new version (3.0.0) release that contains it so please do let me know if you run into any issues with it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants