This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Fix: added json schema draft version to not depend on an implementations default version if entry does not exist ons default version if entry does not exist #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons default version if entry does not exist
|
@jstoiko seems I don't have permissions to add reviewers so I hope this will do to keep track that you are going to review this sometime. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds $schema entries to avoid having the implementation decide which json schema draft to use. This is important as the schemas changed have
requiredkeys with boolean values which is only possible in draft 3.Another option is to migrate all of these schemas to draft-4 but the $schema key should also be added.