Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of Left, Right, Home and End keys, Update Dependencies #1

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Jul 9, 2024

Related Item(s)

#2245

Changes

  • Removed code that handled behavior of the Right, Left, Home and End keys
  • Updated dependencies (by running npm update)
  • Changed the hashing algorithm used during building from md4 to md5

Testing

Testing would have to be done using a local RAMP repo

  1. Within package.json, change the line "@ramp4-pcar4/vue3-treeselect": "github:ramp4-pcar4/vue3-treeselect" to "@ramp4-pcar4/vue3-treeselect": "github:IshavSohal/vue3-treeselect",
  2. Run npm install
  3. Run the following to clear any cache
cd node_modules
rm -r .vite
cd ..
npm cache clear --force
  1. Run npm run dev to run an instance of RAMP
  2. In the RAMP instance, press F12 to open devtools
  3. Open any sample with a wizard (ex. Sample 27)
  4. Click on the + in the legend to open the wizard
  5. Add https://section917.canadacentral.cloudapp.azure.com/arcgis/rest/services/TestData/EcoAction/MapServer as a Map Image Layer
  6. Click though the wizard to reach Step 3, where the tree picker appears
  7. Type natu
  8. Click the Left arrow key, and observe that the cursor moves to the left on the first click
  9. Click the Right arrow key, and observe that the cursor moves to the right on the first click
  10. Click the Home key, and observe that the cursor moves to the very beginning of the search term
  11. Click the End key, and observe that the cursor moves to the very end of the search term
  12. Click the Down/Up arrow keys, and observe that the currently selected option is highlighted in gray
  13. Throughout this process, observe that there are no errors or warnings in the devtool console

@james-rae
Copy link
Member

Looks good. Will merge on Monday then we can re-build the demo on ramp4-pcar4/ramp4-pcar4#2264 to verify.
No merge today to avoid 💥 on a Friday

@james-rae james-rae merged commit 7a77069 into ramp4-pcar4:main Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants