Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve return type of UuidInterface::compareTo() #508

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Jun 28, 2023

PHPStan can reports some false positives without this.

@enumag enumag requested a review from ramsey as a code owner June 28, 2023 14:01
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #508 (41ea2d7) into 4.x (00945e1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x     #508   +/-   ##
=========================================
  Coverage     95.64%   95.64%           
  Complexity      584      584           
=========================================
  Files            70       70           
  Lines          1561     1561           
=========================================
  Hits           1493     1493           
  Misses           68       68           

@ramsey ramsey merged commit 9308b6a into ramsey:4.x Nov 8, 2023
17 of 18 checks passed
@ramsey
Copy link
Owner

ramsey commented Nov 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants