Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty CAPI variable value to be deserialized without errors #22

Merged

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Apr 24, 2024

This ensures that ”” content is valid under generated serde rules for variables with empty values.

Fixes #21

@Danil-Grigorev Danil-Grigorev force-pushed the apiextensions-json-fix branch 3 times, most recently from 486a5fe to 358b1e4 Compare April 24, 2024 11:41
@Danil-Grigorev
Copy link
Contributor Author

@richardcase fix was merged upstream so I updated kopium to use origin main branch. Do you think it is GTG?

Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Danil-Grigorev 🎉

@richardcase richardcase merged commit f351d5b into rancher-sandbox:main Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when reconciling cluster that uses cluster class
2 participants