Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to GHA #455

Merged
merged 12 commits into from
Apr 30, 2024
Merged

Migration to GHA #455

merged 12 commits into from
Apr 30, 2024

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Apr 11, 2024 •
edited
Loading

  • Adds goreleaser for binary release CI, a standard release tool for go binaries. Preserves the same static link flags as our package script
  • Migrates main CI (build & test) to gha dynamic matrices (linuxamd, linuxarm) x (min_supported_k8s-version, max_supported_k8s_version)
  • Migrates image building CI to using docker-build-and-push action using buildx and docker manifests.

⚠️ Does not include arm64 support, will follow up in a separate PR on this

image
image

@alexandreLamarre
remove drone CI
a0f45f2 
Signed-off-by: Alexandre Lamarre <[email protected]>
@alexandreLamarre alexandreLamarre marked this pull request as ready for review April 23, 2024 17:42
mallardduck
mallardduck reviewed Apr 23, 2024
View reviewed changes
.goreleaser.yaml Outdated Show resolved Hide resolved
ericpromislow
ericpromislow reviewed Apr 23, 2024
View reviewed changes
scripts/integration Outdated Show resolved Hide resolved
ericpromislow
ericpromislow reviewed Apr 23, 2024
View reviewed changes
scripts/integration Outdated Show resolved Hide resolved
ericpromislow
ericpromislow requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits. The CI files look good, and it's helpful that the github actions are passing.

@alexandreLamarre alexandreLamarre marked this pull request as draft April 25, 2024 16:42
@alexandreLamarre
linting, style & typos
3ecff94 
Signed-off-by: Alexandre Lamarre <[email protected]>
@alexandreLamarre
add timeout to setup-cluster
8b3a8ff 
Signed-off-by: Alexandre Lamarre <[email protected]>
@alexandreLamarre alexandreLamarre marked this pull request as ready for review April 29, 2024 16:26
mallardduck
mallardduck approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ericpromislow - IIRC you said you would handle this round of release stuff for BRO. So if we merge this before that release then this will most directly affect you, so i'll mostly defer to your call - beyond this initial review.

ericpromislow
ericpromislow approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@ericpromislow ericpromislow merged commit f83e024 into release/v5.0 Apr 30, 2024
3 checks passed
@alexandreLamarre alexandreLamarre deleted the gha branch May 1, 2024 17:50
@MKlimuszka MKlimuszka mentioned this pull request May 8, 2024
Closed
This was referenced May 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mallardduck mallardduck mallardduck approved these changes

@ericpromislow ericpromislow ericpromislow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandreLamarre @ericpromislow @mallardduck