[Backport][v2.7] GHA CI #472

alexandreLamarre · 2024-05-13T15:49:08Z

Backport of :
#455
#457
#469

Signed-off-by: Alexandre Lamarre <[email protected]>

.github/workflows/publish.yaml

Signed-off-by: Alexandre Lamarre <[email protected]>

Compile release binaries only for linux amd & arm Change release binary name format to match previous one Signed-off-by: Alexandre Lamarre <[email protected]>

Signed-off-by: Alexandre Lamarre <[email protected]>

…uting Signed-off-by: Alexandre Lamarre <[email protected]>

Signed-off-by: Alexandre Lamarre <[email protected]>

ericpromislow · 2024-06-17T17:32:57Z

.github/workflows/ci.yaml

+  workflow_call:
+  push:
+    branches:
+      - release/v5.0


Shouldn't this just be release/v* so we don't have to keep updating it?

ericpromislow · 2024-06-17T17:33:24Z

.github/workflows/ci.yaml

+  build:
+    strategy:
+      matrix:
+        os : [ 


extra white-space at the end

ericpromislow · 2024-06-17T17:33:58Z

.github/workflows/ci.yaml

+jobs:
+  build:
+    strategy:
+      matrix:


Alternative to run on both platforms:

strategy: matrix: archBox: - { arch: amd64, vmArch: x64 } - { arch: arm64, vmArch: arm64 } runs-on: runs-on,runner=1cpu-linux-${{ matrix.archBox.vmArch }},run-id=${{ github.run_id }} ```

ericpromislow · 2024-06-17T17:34:51Z

.github/workflows/ci.yaml

+        with:
+          name: bro-build-artifacts-${{ matrix.os }}
+          path: ./dist/artifacts/
+      - name : Debug


I use this too, but I assume we want to pull out the Debug parts once everything's working

ericpromislow · 2024-06-17T17:35:30Z

.github/workflows/publish.yaml

+      - name : Checkout repository
+        uses: actions/checkout@v4
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3 


Extra white-space at end of line 37

ericpromislow · 2024-06-17T17:49:45Z

.github/workflows/scripts/setup-cluster.sh

+}
+
+k3d cluster delete $CLUSTER_NAME || true
+k3d cluster create $CLUSTER_NAME --image "docker.io/rancher/k3s:${K3S_VERSION}"


The docker.io/ part isn't needed

ericpromislow · 2024-06-17T17:51:33Z

.github/workflows/scripts/setup-cluster.sh

+        echo "Timeout reached, exiting..."
+        exit 1
+    fi
+


Space on line 30 not needed (git diff is complaining about these)

ericpromislow · 2024-06-17T17:52:22Z

package/Dockerfile

 FROM registry.suse.com/bci/bci-micro:latest
-COPY bin/backup-restore-operator /usr/bin/
-ENTRYPOINT ["backup-restore-operator"]
+COPY --from=builder /usr/src/app/bin/backup-restore-operator  /usr/bin/


extra space after backup-restore-operator

ericpromislow · 2024-06-17T17:53:13Z

scripts/integration

 }

-source $(dirname $0)/version
+source ./scripts/version


I thought leaving it as $(dirname $0) would be better in case you're running this from some other directory

ericpromislow · 2024-06-17T18:10:16Z

scripts/integration

@@ -1,36 +1,16 @@
 #!/bin/bash
 set -ex
 function echo_with_time {
-    echo "$(date --utc +%Y-%m-%dT%H:%M:%SZ) "$@""
+    echo "$(date --utc +%Y-%m-%dT%H:%M:%SZ) $*"


The --utc option isn't recognized on Darwin (/bin/date so I'm not running some variant) but -u is a shortcut for it on linux. So better to just go with -u

ericpromislow

Just white-space issues, although you might want to try the dual-runner solution and see if CI succeeds on both platforms.

Will wait until 2.9 is doe

mallardduck · 2024-07-19T00:57:22Z

I think that technically for both of these backports, we don't even need to bring the .github folder over. GHA always finds workflows based on the current default branch. And we're not likely to ever "rollback" and use an older branch as default, so they'll just be unused blobs of data on old branches.

As we move forward the new base branch (eventually release/v6.0) will inherit the same workflows we have when we branch. And for example, if we need different release processes for 6.0 while still using "old" workflows for old branches we would maintain both workflows in parallel and differ based on branches/tags that trigger them.

What is probably worth backporting though are mainly the parts that remove drone and bring the new build scripts. Since I think only scripts we put under .github will be in the context of the running action by default. And other scripts (like ./scripts folder) are accessed via what the GHA clones.

JK - in the process of my renovate testing today I realized that when you create a tag/release it will use workflows that exist in that local repo at that commit. Not the default branch .github/workflows file like I thought it did.

...just noticed the GHA job that ran after I added this fix has the value empty. read the docs harder on GH and found out I read the wrong docs and mixed env var and context. this changes it to use a valid context within the GHA

alexandreLamarre and others added 15 commits May 13, 2024 11:41

remove drone CI

bd34476

Signed-off-by: Alexandre Lamarre <[email protected]>

add goreleaser to publish BRO

9ee9cae

Signed-off-by: Alexandre Lamarre <[email protected]>

Add CI install/setup scripts

e15105c

Signed-off-by: Alexandre Lamarre <[email protected]>

Update dapper scripts to be more ergonomic

836d477

Signed-off-by: Alexandre Lamarre <[email protected]>

Update dockerfile to not copy binary

e524b91

Signed-off-by: Alexandre Lamarre <[email protected]>

Introduce GHA for build & testing in CI

caa0b6c

Signed-off-by: Alexandre Lamarre <[email protected]>

Introduce GHA for binary release CI

911f368

Signed-off-by: Alexandre Lamarre <[email protected]>

Introduce GHA for publishing images to docker

be43f56

Signed-off-by: Alexandre Lamarre <[email protected]>

document integration testing methods

c8d55b2

Signed-off-by: Alexandre Lamarre <[email protected]>

read vault secrets from EIO

627e9cd

Signed-off-by: Alexandre Lamarre <[email protected]>

linting, style & typos

2142bcd

Signed-off-by: Alexandre Lamarre <[email protected]>

add timeout to setup-cluster

3f3baca

Signed-off-by: Alexandre Lamarre <[email protected]>

fix typo in local ref for CI actions

fdcc858

Signed-off-by: Alexandre Lamarre <[email protected]>

tweak permissions and dispatch types for GHA

84c45cf

Signed-off-by: Alexandre Lamarre <[email protected]>

require CI to pass before attempting to publish

f6daf5e

Signed-off-by: Alexandre Lamarre <[email protected]>

alexandreLamarre commented May 13, 2024

View reviewed changes

.github/workflows/publish.yaml Show resolved Hide resolved

alexandreLamarre added 5 commits May 13, 2024 14:43

update k8s version support, based on rancher support matrix

f066b36

Signed-off-by: Alexandre Lamarre <[email protected]>

Add packaged release charts to github releases

03d8bb5

Compile release binaries only for linux amd & arm Change release binary name format to match previous one Signed-off-by: Alexandre Lamarre <[email protected]>

remove unecessary comments from goreleaser

c30011a

Signed-off-by: Alexandre Lamarre <[email protected]>

(test bug fix) source versions in package-helm script instead of exec…

c46837b

…uting Signed-off-by: Alexandre Lamarre <[email protected]>

add race flag to hull tests

110c94f

Signed-off-by: Alexandre Lamarre <[email protected]>

alexandreLamarre marked this pull request as ready for review June 13, 2024 10:56

alexandreLamarre requested a review from ericpromislow as a code owner June 13, 2024 10:56

ericpromislow reviewed Jun 17, 2024

View reviewed changes

.github/workflows/ci.yaml

build:

strategy:

matrix:

os : [

Copy link

Collaborator

ericpromislow Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra white-space at the end

ericpromislow reviewed Jun 17, 2024

View reviewed changes

ericpromislow previously requested changes Jun 17, 2024

View reviewed changes

mallardduck added 5 commits July 25, 2024 17:02

set GORELEASER_CURRENT_TAG as GHA vars.GITHUB_REF_NAME

56dee5b

merge jobs with the same trigger and common pre-steps

b02c35e

fix but with tag variable used

91cdb11

...just noticed the GHA job that ran after I added this fix has the value empty. read the docs harder on GH and found out I read the wrong docs and mixed env var and context. this changes it to use a valid context within the GHA

update CI to also run on PRs pointing at 3 dot releases

c7b1365

adjust pattern match to use [0-9]+

348914e

alexandreLamarre requested a review from a team as a code owner July 25, 2024 21:03

mallardduck approved these changes Jul 26, 2024

View reviewed changes

mallardduck merged commit 39207bc into release/v3.0 Jul 26, 2024
3 checks passed

mallardduck deleted the backport-gha-ci-3 branch October 4, 2024 17:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport][v2.7] GHA CI #472

[Backport][v2.7] GHA CI #472

alexandreLamarre commented May 13, 2024

ericpromislow Jun 17, 2024

ericpromislow Jun 17, 2024

ericpromislow Jun 17, 2024

ericpromislow Jun 17, 2024

ericpromislow Jun 17, 2024

ericpromislow Jun 17, 2024

ericpromislow Jun 17, 2024

ericpromislow Jun 17, 2024

ericpromislow Jun 17, 2024

ericpromislow Jun 17, 2024

ericpromislow left a comment

mallardduck commented Jul 19, 2024 •

edited

Loading

[Backport][v2.7] GHA CI #472

[Backport][v2.7] GHA CI #472

Conversation

alexandreLamarre commented May 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericpromislow left a comment

Choose a reason for hiding this comment

mallardduck commented Jul 19, 2024 • edited Loading

mallardduck commented Jul 19, 2024 •

edited

Loading