disable cgo #353
disable cgo #353
Conversation
Signed-off-by: Brooks Newberry <[email protected]>
| @@ -1,7 +1,7 @@ | |||
| BINARIES = gen_release_notes gen_release_report backport semv rancher_release test_coverage upstream_go_version rke2_release release | |||
| ARCHS ?= amd64 arm64 | |||
| OSs ?= linux darwin freebsd | |||
| GO_COMPILE = GOOS=$${os} GOARCH=$${arch} CGO_ENABLED=1 $(GO) build -tags $(TAGS) -v -ldflags "$(LDFLAGS)" -o $@-$${os}-$${arch} | |||
| GO_COMPILE = GOOS=$${os} GOARCH=$${arch} $(GO) build -tags $(TAGS) -v -ldflags "$(LDFLAGS)" -o $@-$${os}-$${arch} | |||
There was a problem hiding this comment.
I thought we needed this on since we're using the hardened image?
There was a problem hiding this comment.
Building in the hardened image would also work, but right now builds are being done of the Ubuntu runner vm, not in a container.
The Ubuntu environment would need extra setup, cross compiling for FreeBSD doesn't work with the installed libc, and that issue only cropped up when importing a particular library.
There was a problem hiding this comment.
I can see I'm wrong about that. I'll cancel review for now.
There was a problem hiding this comment.
I added FreeBSD since I occassionally work from my FreeBSD machine and provides a bulk of MacOS' system but we can drop it entirely. It's not even slightly a requirement.
This PR disables CGO to make it easier to support a range of build environments. The resulting binaries are still statically linked.