Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry Attest provenance step #515

Merged
merged 2 commits into from
Dec 11, 2024
Merged

retry Attest provenance step #515

merged 2 commits into from
Dec 11, 2024

Conversation

brooksn
Copy link
Contributor

@brooksn brooksn commented Dec 11, 2024

Requests to download prime registry manifests appear to fail intermittently (see https://github.com/rancher/ingress-nginx/actions/runs/12260568096/job/34224296299).
This PR adds a retry capability.

@brooksn brooksn requested review from pjbgf and rafaelbreno December 11, 2024 13:20
@pjbgf
Copy link
Member

pjbgf commented Dec 11, 2024

@brooksn good job! Overall this should be safe, apart from the cases whereby the image was not correctly pushed to the Prime registry - on those cases the errors are not intermittent.

Signed-off-by: Brooks Newberry <[email protected]>
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn brooksn requested a review from briandowns December 11, 2024 16:41
@brooksn brooksn merged commit f0ed6cd into rancher:master Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants