Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpm tooling for handling rpms #537

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

vitorsavian
Copy link
Member

@vitorsavian vitorsavian commented Feb 5, 2025

this new tool will resolve the issue we had with rpm-s3

I tried to write in go, but after some research the dnf package made me do that in python

btw, I don't know to much about python (so you can see some weird stuff)

Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitorsavian vitorsavian requested a review from brandond February 6, 2025 00:17
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Have you tested it against any of the current channels?

@vitorsavian
Copy link
Member Author

vitorsavian commented Feb 7, 2025

Yeah, I did test against the latest channel, I tested with x86_64 and aarch64

@vitorsavian vitorsavian merged commit 46b9dda into rancher:master Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants