Use publish-image action #7022
Use publish-image action #7022
Conversation
| make-target: publish-image-runtime | ||
|
|
||
| public-repo: rancher | ||
| public-username: ${{ env.DOCKER_USERNAME }} |
There was a problem hiding this comment.
Should we use secrets for all the sensitive data?
public-repo: rancher
public-username: ${{ secrets.DOCKER_USERNAME }}
public-password: ${{ secrets.DOCKER_PASSWORD }}
prime-repo: rancher
prime-registry: ${{ secrets.PRIME_REGISTRY }}
prime-username: ${{ secrets.PRIME_REGISTRY_USERNAME }}
prime-password: ${{ secrets.PRIME_REGISTRY_PASSWORD }}
There was a problem hiding this comment.
We're getting those values from vault, the "Read secrets" step will retrieve them from vault and set it as envs. The Github CI will mask those, so no secrets leak.
scripts/publish-manifest-runtime
Outdated
| docker manifest push ${REPO}/${PROG}-runtime:${DOCKERIZED_VERSION} | ||
|
|
||
| if [ -n "$IID_FILE_FLAG" ]; then |
There was a problem hiding this comment.
Please stay consistent with the use of parenthesis and curly braces for make and shell variables.
Signed-off-by: Brooks Newberry <[email protected]>
brooksn
force-pushed
the
push-image-action
branch
from
b3c0c4d to
3f27c9e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7022 +/- ##
==========================================
- Coverage 25.11% 17.75% -7.36%
==========================================
Files 33 32 -1
Lines 2839 2827 -12
==========================================
- Hits 713 502 -211
- Misses 2079 2283 +204
+ Partials 47 42 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Brooks Newberry <[email protected]>
Signed-off-by: Brooks Newberry <[email protected]>
scripts/build-image-runtime
Outdated
| DOCKER_BUILDKIT=${DOCKER_BUILDKIT:-1} docker image build \ | ||
| --sbom=true \ | ||
| --builder ${PROG} \ | ||
| ${IID_FILE_FLAG} \ |
There was a problem hiding this comment.
What is this flag, and where does the env var setting it come from?
Signed-off-by: Brooks Newberry <[email protected]>
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
rancher/ecm-distro-tools#481
User-Facing Change
Further Comments